On 2011/03/28 22:44:55, t.daniels_treda.co.uk wrote:
>
http://codereview.appspot.com/4313047/diff/1/lily/lyric-hyphen.cc#newcode46
> lily/lyric-hyphen.cc:46: if (Paper_column::when_mom > (bounds[LEFT]->get_column ()).grace_part () != Rational (0) > I think you could fold this into the existing code below: > > if (bounds[LEFT]->break_status_dir () > && (Paper_column::when_mom (bounds[LEFT]).main_part () > == Paper_column::when_mom (bounds[RIGHT]->get_column > ()).main_part > ()))
Done, but I don't like emacs' indentation here. Do you think this makes it clearer?
Sorry, I meant replace all the code (your added code, and the next lines which suppress hyphens after a line break where there's no grace note) with the example code I posted. I'm pretty sure it covers both cases without having to check grace_part_. TBH, the code here looks like it could be handled via ly:spanner::kill-zero-spanned-time (with a minor tweak to ignore grace notes): this has the benefit of making the behaviour tweakable. http://codereview.appspot.com/4313047/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
