good start! I'm not certain about the location of the text file (having it inside scripts/ seems a bit weird), but the framework is definitely there.
http://codereview.appspot.com/4428077/diff/1/scripts/build/extract_texi_filenames.py File scripts/build/extract_texi_filenames.py (right): http://codereview.appspot.com/4428077/diff/1/scripts/build/extract_texi_filenames.py#newcode65 scripts/build/extract_texi_filenames.py:65: known_missing_files = '' could this be a list instead of a string? http://codereview.appspot.com/4428077/diff/1/scripts/build/extract_texi_filenames.py#newcode87 scripts/build/extract_texi_filenames.py:87: known_missing_files_file = a known_missing_files.append(a) http://codereview.appspot.com/4428077/diff/1/scripts/build/extract_texi_filenames.py#newcode94 scripts/build/extract_texi_filenames.py:94: missing_files = open (known_missing_files_file, 'r') missing_Files = open(...).readlines() then you don't need the next two lines. http://codereview.appspot.com/4428077/diff/1/scripts/build/extract_texi_filenames.py#newcode121 scripts/build/extract_texi_filenames.py:121: if known_missing_files.find (include_name) == -1: if include_name in known_missing_files: http://codereview.appspot.com/4428077/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
