----- Original Message -----
From: <percival.music...@gmail.com>
To: <philehol...@googlemail.com>
Cc: <re...@codereview.appspotmail.com>; <lilypond-devel@gnu.org>
Sent: Sunday, May 15, 2011 9:19 PM
Subject: Re: Making website build almost completely quiet (issue4515042)
could we get a subject like "add a -q quiet flag to make websit scripts"
?
I've given the patch set that name. Is that OK?
Also, don't mention that it includes previous patches -- that's
implicitly done everywhere in git (or any source versioning system)
This was to the comment that it was repeating previous changes - I knew
that - it was because the previous stuff hadn't been pushed.
http://codereview.appspot.com/4515042/diff/10001/make/website.make
File make/website.make (right):
http://codereview.appspot.com/4515042/diff/10001/make/website.make#newcode7
make/website.make:7:
IMO this stuff isn't security -- could you move it elsewhere in the
file?
Moved it down.
Also, could you move the quiet-run = true up so that it's in the same
"paragraph" as the commented-out stuff? Logically, setting
quiet-run=true is a separate stage from the quiet-flag.
Tricky. The only way to do this is to move it above the comment that
describes it. As it is, we have a "not used but available if you uncomment"
paragraph and a "does the quiet business" paragraph. I think this is OK.
http://codereview.appspot.com/4515042/diff/10001/scripts/build/bib2texi.py
File scripts/build/bib2texi.py (right):
http://codereview.appspot.com/4515042/diff/10001/scripts/build/bib2texi.py#newcode63
scripts/build/bib2texi.py:63: quiet_flag = ''
the lilypond python style is to use 4 spaces per indent.
Sorry. Using gedit defaults. Now corrected.
http://codereview.appspot.com/4515042/
--
Phil Holmes
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
