http://codereview.appspot.com/4490045/diff/12001/lily/completion-note-heads-engraver.cc File lily/completion-note-heads-engraver.cc (right):
http://codereview.appspot.com/4490045/diff/12001/lily/completion-note-heads-engraver.cc#newcode207 lily/completion-note-heads-engraver.cc:207: event->set_property("autosplit-end", ly_bool2scm (false)); On 2011/05/28 20:27:13, karin.hoethker wrote:
However, some people consider inline conditions not to be very readable (for a (Java) example see AvoidInlineConditionals at http://checkstyle.sourceforge.net/config_coding.html). Although this
is not an
extreme case, I'd rather vote for readability and leave the code as it
is. FWIW, I prefer Karin's formulation: if (blah) func(true); else func(false); However, David and Pal combined have at least 10 times as much experience with lilypond C++ code as I do, so I think it would be best if this conditional were changed. http://codereview.appspot.com/4490045/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
