2011/6/11  <carl.d.soren...@gmail.com>:
Looks good, but untested.  I'll test it when I can.

Ok. Don't forget to make clean in build/mf - there are still missing
dependencies.

Thanks!


http://codereview.appspot.com/4273119/diff/3001/mf/feta-noteheads.mf
File mf/feta-noteheads.mf (right):

http://codereview.appspot.com/4273119/diff/3001/mf/feta-noteheads.mf#newcode45
mf/feta-noteheads.mf:45: numeric black_notehead_width;
On 2011/06/10 23:12:15, Carl wrote:
Perhaps a comment here to indicate that we have deliberately *not*
used a save
statement for black_notehead_width in order to allow it to be a global
variable
available for other .mf files.  This will help keep people from saying
"Hey --
good practice says to make local variables; let's make it local"

Done.

http://codereview.appspot.com/4273119/

_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to