On Jun 12, 2011, at 5:49 PM, n.putt...@gmail.com wrote: > On 2011/06/05 10:18:18, mike_apollinemike.com wrote: >> On Jun 2, 2011, at 9:00 PM, mailto:n.putt...@gmail.com wrote: > >>> >>> http://codereview.appspot.com/4527086/diff/7002/scm/output-lib.scm >>> File scm/output-lib.scm (right): >>> >>> > http://codereview.appspot.com/4527086/diff/7002/scm/output-lib.scm#newcode795 >>> scm/output-lib.scm:795: (define-public > (glissando::before-line-breaking >>> grob) >>> Possibly silly question: can't you fold this into callbacks for >>> left-bound-info/right-bound-info instead? > >> Sorry - I don't get what you mean :( Could you please elaborate? > > You're calculating a value for 'Y which you add back into bound-details. > This bypasses the default calculation in calc_bound_info (). Why not > caculate 'Y when left-bound-info/right-bound-info is requested, either > directly in C++ or as glissando-specific scheme versions? >
My goal is to bypass the default calculation and replace it with this one, and it is easier to harvest the information about Y placement relative to the staff before line breaking happens. Currently, there is no mechanism in Line_spanner::calc_bound_info that can outsource the Y calculation to another function, and I wouldn't want to code dup all of the parts of Line_spanner::calc_bound_info that are worth keeping into a glissando specific function. Taking that into account, does that seem like the right approach? Cheers, MS _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
