On Jun 21, 2011, at 3:31 PM, Janek Warchoł wrote: > 2011/6/21 m...@apollinemike.com <m...@apollinemike.com>: >> What I meant is that every time you use a magic number (i.e. 0.35), >> consider making it user-tweakable unless you are absolutely sure >> that there is no utility in changing that number. > > Ah, you meant this! :) > well, i think that 0.35 in (ly:grob-property grob 'gap 0.35) means "if > you have trouble reading gap property, use 0.35", so it's only kind of > default value. > As for other numbers, i'm sure that making them user-tweakable will be > overkill. They simply are coefficients in a function that does a very > nitpicky tweak; the function (as a whole) can be controlled by > gap-stretchability and i'm sure it's enough. > Personally i suppose that noone in the world - except me - will ever > care about gap-stretchability value, leave alone the coefficients in > the funciton :)
Sorry sorry - I mis-mis-spoke (I should have read my previous post). What I meant is that these values could be wrapped up into a details property. The argument that user-tweakability is overkill isn't necessarily a bad thing - check out the `details' property for the Slur and Beam grobs. By creating a similar details list, it'd be more LilyPond-esque, which makes the code easier to read (and, on the off chance that someone actually wants to modify this (which is admittedly rare), they'll be able to w/o having to change the source). Cheers, MS _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
