Hi Carl,

This LGTM, though the regtest could do with a bit of tidying.

A more correct approach would be to filter interfaces since the
Ligature_engraver also potentially acknowledges PitchTrillGroup.  It's
probably not worth the bother though: it does have an event-cause and is
ignored by the ligature engravers; furthermore, it's unlikely
\pitchedTrill would be used in conjunction with such ligatures.

Cheers,
Neil


http://codereview.appspot.com/4667055/diff/2001/lily/ligature-engraver.cc
File lily/ligature-engraver.cc (right):

http://codereview.appspot.com/4667055/diff/2001/lily/ligature-engraver.cc#newcode199
lily/ligature-engraver.cc:199: if (info.event_cause ()) // Ignore
AmbitusNoteHead which has no event_cause
if (info.event_cause ()
    && ligature_)

http://codereview.appspot.com/4667055/

_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to