On 2011/07/26 06:14:47, mike_apollinemike.com wrote:
On Jul 26, 2011, at 5:01 AM, mailto:hanw...@gmail.com wrote:
> regtest missing. > > > http://codereview.appspot.com/4813048/diff/3001/lily/slur-scoring.cc > File lily/slur-scoring.cc (right): > >
http://codereview.appspot.com/4813048/diff/3001/lily/slur-scoring.cc#newcode286
> lily/slur-scoring.cc:286: end_ys[d] += additional_ys + 0.5; // 0.5 = > m4g1c padding over extra encompass. make tweakable? > "magic" > > Do you need the 0.5 at all? The quanting and the shape of the slur > already offer quite some flexibility. >
The test case from the tracker doesn't work without the 0.5, which is
truly a
magic number that represents "that which was necessary to make the
test case
work and not look ugly." I'll add a regtest later today.
Cheers, MS
I did some math to be able to scrub the padding & added a regtest. Cheers, MS http://codereview.appspot.com/4813048/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
