On 31/07/11 22:00, Janek Warchoł wrote:
> 2011/7/31 Wols Lists <antli...@youngman.org.uk>:
>>
>> Assuming that it's okay and is applied, I've redone my docu patch.
>
> Uploaded to Rietveld. I see one trailing whitespace (after "By
> default the chords are"), also there should be two spaces after a
> period which ends sentence.
>
>> The snippet prints a four-bar phrase with just the standard chord
>> (to trap the regression that bit us this time :-), then sets the capoPitch
>> to print transposed chords for the next four bars, then sets capoVertical
>> to print chords one above the other for the last four bars.
>>
>> iirc that will then become the regression test for this feature?
>
> Yes, a regression test should contain a similar snippet. Could you
> add the regression test file to your commit? (create a new file in
> input/regression, named appropriately, use 'git add
> input/regression/<your regtest filename>' to add it to what would be
> commited, and commit.
>
Regression test attached. I've looked at the other regression tests and
tried to make it similar. Basically just put the header stuff above my
test/docu snippet.
Cheers,
Wol
From cf59539f59324583bbe595343e6ea3ca0c754791 Mon Sep 17 00:00:00 2001
From: Wol <anth...@youngman.org.uk>
Date: Sun, 31 Jul 2011 23:13:38 +0100
Subject: [PATCH 3/3] Add regression test for guitar capos
---
input/regression/chord-capo.ly | 44 ++++++++++++++++++++++++++++++++++++++++
1 files changed, 44 insertions(+), 0 deletions(-)
create mode 100644 input/regression/chord-capo.ly
diff --git a/input/regression/chord-capo.ly b/input/regression/chord-capo.ly
new file mode 100644
index 0000000..aa669e2
--- /dev/null
+++ b/input/regression/chord-capo.ly
@@ -0,0 +1,44 @@
+\version "2.14.0"
+
+\header{
+ texidoc="Properties capoPitch, capoVertical: display chordnames, suitably
+transposed for a guitar capo, either in a line or one above the other.
+"
+}
+
+<<
+ \new ChordNames \chordmode {
+ c1
+ r1
+ g1
+ c1
+ \break
+ c1
+ r1
+ g1
+ c1
+ \break
+ c1
+ r1
+ g1
+ c1
+ }
+ \chordmode {
+ c1
+ r1
+ g1
+ c1
+ \break
+ \set ChordNames.capoPitch = #(ly:make-pitch 0 -2 -1/2)
+ c1
+ r1
+ g1
+ c1
+ \break
+ \set ChordNames.capoVertical = ##t
+ c1
+ r1
+ g1
+ c1
+ }
+>>
--
1.7.3.4
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
