LGTM AFAICT, but I am not familiar with chord notation.
Presumably there should be some doc changes? These can either be included with this patch or separately. If the latter, please make a new issue for the docs when this is pushed so we don't forget. http://codereview.appspot.com/4981052/diff/1/ly/chord-modifiers-init.ly File ly/chord-modifiers-init.ly (right): http://codereview.appspot.com/4981052/diff/1/ly/chord-modifiers-init.ly#newcode30 ly/chord-modifiers-init.ly:30: \normal-size-super #(ly:export (ly:wide-char->utf-8 #x00f8)) please replace tab with spaces (I know you didn't insert it, but we want to remove tabs in the source ASAP) http://codereview.appspot.com/4981052/diff/1/scm/chord-ignatzek-names.scm File scm/chord-ignatzek-names.scm (right): http://codereview.appspot.com/4981052/diff/1/scm/chord-ignatzek-names.scm#newcode175 scm/chord-ignatzek-names.scm:175: (add-markups (map (lambda (x) (glue-word-to-step add-pitch-prefix x)) tab http://codereview.appspot.com/4981052/diff/1/scm/chord-ignatzek-names.scm#newcode189 scm/chord-ignatzek-names.scm:189: (list invsep (name-note bass-pitch #f)) tabs http://codereview.appspot.com/4981052/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
