Mostly LGTM, apart from one calculation you do four times. Do it once once and save as a variable and use that.
Cheers, Ian http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf File mf/feta-noteheads.mf (right): http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf#newcode120 mf/feta-noteheads.mf:120: foobar = quanted_line_length * staff_space; % because you use 'quanted_line_length * staff_space' four times in the code below http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf#newcode123 mf/feta-noteheads.mf:123: top y2 = quanted_line_length * staff_space; bot y1 = -foobar; top y2 = foobar; % see comment above http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf#newcode133 mf/feta-noteheads.mf:133: top y2 = quanted_line_length * staff_space; top y2 = foobar; % see comment above http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf#newcode140 mf/feta-noteheads.mf:140: bot y3 = -quanted_line_length * staff_space; bot y3 = -foobar; % see comment above http://codereview.appspot.com/4962072/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
