Hi Neil,

2011/9/14  <n.putt...@gmail.com>:
> http://codereview.appspot.com/4951062/diff/11001/input/regression/kievan-notes.ly
> File input/regression/kievan-notes.ly (right):
>
> http://codereview.appspot.com/4951062/diff/11001/input/regression/kievan-notes.ly#newcode11
> input/regression/kievan-notes.ly:11: \override NoteHead #'stencil =
> #ly:text-interface::print
> NoteHead doesn't have an interface for 'text, so this regression test
> will spit out warnings when compiled (to see run it with
> -dcheck-internal-types).
>
> The canonical method is to use grob::interpret-markup, but this is still
> rather hackish.  It would be preferable to add the infrastructure which
> switches the glyphs (if possible, a 'style setting).

I'm not sure what is your opinion on this patch currently.  Do you
agree to push it if it doesn't break make, make doc and regtests?  Do
you agree with my comment no.7
http://code.google.com/p/lilypond/issues/detail?id=1873#c7 ?

cheers,
Janek

_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to