Rather indecipherable. The 350 lines of code re-ordering make it difficult to find the change in function. Therefore I am not willing to say LGTM, and looks like nobody else was, either.
It looks like the intent is, if consistent_broken_slope=#t, to join the parts of a broken beam together and present the combination to Beam_scoring_problem, but... http://codereview.appspot.com/4961041/diff/60001/lily/beam-quanting.cc File lily/beam-quanting.cc (right): http://codereview.appspot.com/4961041/diff/60001/lily/beam-quanting.cc#newcode202 lily/beam-quanting.cc:202: for (vsize i = 0; i < beams.size (); i++) When there is more than one beam in 'beams' what do you intend the members Beam_scoring_problem to represent ? The beam as if it were on one line, but allowing the extra horizontal span due to the line-break ? Should the members like segments_ and is_knee_ include both halves of the beam ? http://codereview.appspot.com/4961041/diff/60001/lily/beam-quanting.cc#newcode947 lily/beam-quanting.cc:947: final_positions[RIGHT] -= (1 - normalized_endpoints[RIGHT]) * y_length; At what horizontal locations are these final_positions? First and last stems or the end of the beam including overhang or x_span_ ? http://codereview.appspot.com/4961041/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
