Only stylistic comments:

http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py
File scripts/build/output-distance.py (right):

http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py#newcode8
scripts/build/output-distance.py:8: from cgi import escape
Since the style within lilypond's python sources is to import the module
into the namespace, it would be nice to keep to that style, e.g. "import
cgi" here, and then...

http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py#newcode462
scripts/build/output-distance.py:462: str = '<font
size="-2"><pre>%s</pre></font>' % escape(str)
...use "cgi.escape (str)" here. The space before the parenthesis is also
to keep the consistent style.

http://codereview.appspot.com/5342042/

_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to