----- Original Message ----- From: "Graham Percival" <gra...@percival-music.ca>
To: "Phil Holmes" <m...@philholmes.net>
Cc: <philehol...@googlemail.com>; <d...@gnu.org>; <julien.ri...@gmail.com>; <lilypond-devel@gnu.org>; <re...@codereview-hr.appspotmail.com>
Sent: Monday, March 12, 2012 7:27 PM
Subject: Re: Various updates to reduce make doc output (issue 5727055)


On Mon, Mar 12, 2012 at 06:31:35PM -0000, Phil Holmes wrote:
----- Original Message ----- From: <julien.ri...@gmail.com>
To: <philehol...@googlemail.com>; <d...@gnu.org>;
<gra...@percival-music.ca>; <m...@philholmes.net>
Cc: <lilypond-devel@gnu.org>; <re...@codereview-hr.appspotmail.com>
Sent: Monday, March 12, 2012 6:18 PM
Subject: Re: Various updates to reduce make doc output (issue 5727055)

>--quiet shouldn't suppress warning messages, everything else looks good.

The problem with this warning message is that, as part of build, you
can't fix it - if you want to test converting midi with more than 5
voices to lilypond, you'll get a message on screen, which is not
what's wanted.

Can't you redirect the midi2ly call to a log file?  If a test is
deliberately checking that a midi file with more than 5 voices
should produce a warning, then we _want_ that warning saved to a
logfile so we can check that the warning doesn't go away.
Conversely, if we don't want that warning, then it's good to save
it in a logfile so that future programmers can see the problem
easily.

- Graham

It seems just not worth it. We _never_ want to check warnings as part of make doc. That's what regression tests are for.

--
Phil Holmes


_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to