http://codereview.appspot.com/5908043/diff/1/lily/beam.cc File lily/beam.cc (right):
http://codereview.appspot.com/5908043/diff/1/lily/beam.cc#newcode1326 lily/beam.cc:1326: || beam->get_property_data ("direction") == ly_symbol2scm ("calculation-in-progress")) On 2012/04/25 06:29:14, mike7 wrote:
On 2012/04/25 06:21:54, Keith wrote: > Mike, any idea why you added this? > It just adds to the cases where we lie and say the beam is on the
centerline.
> It causes this to go wrongly > << {b''8[ r16. g''32] } \\ {r8 <f' g' a' b'>16. r } >> > > Take a look at today's patchset at > http://codereview.appspot.com/6035053/
If this bit isn't there, a circular dependency could be called up
later on in
the function while looking for the direction. I forget the exact
reason for the
circular dependency, but it crept up in several regtests. Like
several other
pure functions, I have it cowardly fail if a pure estimation is not
possible
because of circular dependencies, which usually has a minimal impact
on the
typeset result.
Isn't it a good idea to make a comment in the code to this part of if condition? This would make that fragment of code clear for other developers. http://codereview.appspot.com/5908043/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel