Reviewers: Keith,
Message:
Thanks for the review!
http://codereview.appspot.com/6302097/diff/1/lily/line-spanner.cc
File lily/line-spanner.cc (right):
http://codereview.appspot.com/6302097/diff/1/lily/line-spanner.cc#newcode373
lily/line-spanner.cc:373: me->warning (_ ("Line spanner's left point is
to the right of its right point."));
On 2012/06/20 05:31:50, Keith wrote:
if 'me' supports me->origin()->warning()
it will tell the user which line spanner(s)
::origin is only defined for stream events, music, context defs and
books.
Description:
Issues warning for negative-spanning line spanner.
Please review this at http://codereview.appspot.com/6302097/
Affected files:
M lily/line-spanner.cc
Index: lily/line-spanner.cc
diff --git a/lily/line-spanner.cc b/lily/line-spanner.cc
index
2d43a71fa4f0006943990e89e390fcdf4c71b28b..f42628820e6e64b6a0ba019d93f0bf8666125472
100644
--- a/lily/line-spanner.cc
+++ b/lily/line-spanner.cc
@@ -21,6 +21,7 @@
#include "axis-group-interface.hh"
#include "font-interface.hh"
#include "grob-interface.hh"
+#include "international.hh"
#include "item.hh"
#include "lily-proto.hh"
#include "line-interface.hh"
@@ -368,6 +369,8 @@ Line_spanner::print (SCM smob)
arrows[LEFT],
arrows[RIGHT]));
}
+ else
+ me->warning (_ ("Line spanner's left point is to the right of its
right point."));
line.translate (Offset (-me->relative_coordinate (commonx, X_AXIS),
simple_y ? 0.0 : -me->relative_coordinate
(my_common_y, Y_AXIS)));
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
