----- Original Message ----- From: <gra...@percival-music.ca>
To: <philehol...@googlemail.com>; <tdanielsmu...@googlemail.com>
Cc: <lilypond-devel@gnu.org>; <re...@codereview-hr.appspotmail.com>
Sent: Saturday, July 14, 2012 2:39 AM
Subject: Re: Adds support for cross-staff-stems (issue 6344092)



http://codereview.appspot.com/6344092/diff/7001/input/regression/cross-staff-stems.ly
File input/regression/cross-staff-stems.ly (right):

http://codereview.appspot.com/6344092/diff/7001/input/regression/cross-staff-stems.ly#newcode2
input/regression/cross-staff-stems.ly:2:
Sorry, I was unclear.  I meant to ask for your new snippet to be a
regtest in *addition* to a snippet, not as a replacement.  We do not
expect users to look at regtests, so it's important to discuss this
functionality in a snippet or the docs.

In addition, the regtest should still have a texidoc header (like other
regtests) -- I meant to only ask you to remove the lsrtags and doctitle
from the regtest version of the snippet.

http://codereview.appspot.com/6344092/

I think I intended it to remain in snippets/new - it looks like my patch hasn't picked it up. I'll also add texidoc to explain the regtest's function.

It's my intention to update the cross-staff stems part of the NR once this is in master.

New patch will be created over the weekend.

--
Phil Holmes

_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to