hi all, >> Keith, I hope I fixed lyrics-bar.ly. > > > Yes, it comes out nicely. > > >> 1. in repeat-sign.ly the thick-lined staff has now the dots >> outside of staff, while the c++ version had it inside - >> there may be a difference how line-thickness is handled. > > > The latest Scheme version you sent uses the correct staff line thickness. > The last C version you posted used the layout line thickness, for bar lines > and span bars.
thanks for spotting, I use Marc's Scheme code now. > The gap you require to set the dot, dot-y-length + line-thickness + 2 * 0.75 > line-thickness, > includes a lot of space for the gaps on each side of the dot, when the staff > lines are thick. You might be happy with a rule to ensure a minimum > proportion of white-space 1.2( dot-y-length + line-thickness ) ok, I applied this (and did a bit of restructuring to keep lyrics-bar.ly the way we like). I also changed those regtests that show where's the change of dot placement inside or outside staff. I have now four commits: regtest changes plus one change in three (sort of unrelated) functions each in bar-line.scm (colon, extent and line-span computation). what review process do you prefer/suggest? one review per commit or review in one, push in four? p _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel