On 2012/10/24 09:58:12, janek wrote:
LGTM
shall the tracker issues "write doc for this"
It is not as much "write doc for this" as the function itself has its docs updated. It is more "update the existing docs in the manual to reflect the change".
and "add a regtest for this" be added now or after this patch is pushed? (my concern is to make sure that we won't forget)
I am not planning on working on this myself but that does not preclude someone else from submitting the respective parts which I would then incorporate into the patch. So I would lean towards waiting with creating the doc/regtest issues until the patch is indeed being pushed. http://codereview.appspot.com/6744070/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel