On Sun, Jan 13, 2013 at 05:37:17PM +0000, Adam Spiers wrote: > On Sun, Jan 13, 2013 at 5:35 PM, James <pkx1...@gmail.com> wrote: > > On 13 January 2013 17:27, Adam Spiers <lilypond-de...@adamspiers.org> wrote: > >> On Sun, Jan 13, 2013 at 4:40 PM, Adam Spiers > >> <lilypond-de...@adamspiers.org> wrote: > >> > On Sat, Jan 12, 2013 at 12:52 PM, Adam Spiers > >> > <lilypond-de...@adamspiers.org> wrote: > >> >> On Tue, Jan 8, 2013 at 5:59 PM, Adam Spiers > >> >> <lilypond-u...@adamspiers.org> wrote: > >> >>> On Tue, Jan 8, 2013 at 5:41 PM, Eluze <elu...@gmail.com> wrote: > >> >>>> I've added an issue to the tracker: > >> >>>> > >> >>>> https://code.google.com/p/lilypond/issues/detail?id=3091&thanks=3091&ts=1357666391 > > [snipped] > > >> I have published my fix here and will submit to Rietveld soon: > >> > >> https://github.com/aspiers/lilypond/commits/tie-grace-fix > > > > Don't forget to open a tracker issue (use git-cl - which will open a tracker > > and Rietveld at the same time) as this is what is used for automated Patch > > testing. > > Already done by Eluze - see above.
OK, this fix is now in Rietveld: https://codereview.appspot.com/7108043/ As you can see, I added a regression test-case, but I couldn't figure out how to prove via "make check" etc. that the code actually altered the MIDI output (even though manual testing shows that it clearly does). I followed the CG steps involving "make test-baseline", "make check" etc. but these two files ended up having identical content: ./build/input/regression/out-test-baseline/midi-grace-after-tie.log ./build/input/regression/out-test/midi-grace-after-tie.log i.e. they both wrote to ./build/out/lybook-testdb/83/lily-b715ac6a.midi so a comparison of the new .midi file with a baseline version seems impossible. Am I missing something, or are .midi regressions not implemented? Thanks, Adam _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
