https://codereview.appspot.com/4515158/diff/2009/lily/align-interface.cc File lily/align-interface.cc (right):
https://codereview.appspot.com/4515158/diff/2009/lily/align-interface.cc#newcode222 lily/align-interface.cc:222: dy = max (dy, min_distance); On 2013/02/11 05:01:28, MikeSol wrote:
Couldn't there just be a vector<bool> ignore_me that contains the
result
request_suicide for all elements (when pure)? Then, the for loop
would be
continued for these elements and they wouldn't have to be removed in get_skylines.
I think yes. ('removed_as_empty' would be a good name) That array could be built by get_skylines(), since it already calls pure_height(), which in turn calls request_suicide(..., start, end). To truly distinguish the concepts of 'empty' versus 'removed', we could, in get_skylines line 98 else if ( !(removed_as_empty[i] = request_suicide(elements[i], start, end))) but that results in an additional call to request_suicide() per VertAxisGroup per pass through the line-breaking https://codereview.appspot.com/4515158/diff/2009/lily/align-interface.cc#newcode229 lily/align-interface.cc:229: // So if stretchability=0, treat basic-distance as a minimum-distance. On 2011/06/07 04:48:01, joeneeman wrote:
This is no longer needed, right?
This chunk is now no longer needed. https://codereview.appspot.com/4515158/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel