On 2013/10/23 14:24:33, david.nalesnik wrote:

https://codereview.appspot.com/15850044/diff/120001/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):


https://codereview.appspot.com/15850044/diff/120001/ly/music-functions-init.ly#newcode722
ly/music-functions-init.ly:722: (make-music 'Music)))
Hmm...

Shouldn't the return here be `item' since it is guaranteed to be
music?

The following code

\relative c'' {
   <c e g>-\offset foo #'(-1 . 1) \arpeggio
}

results in a failed file.

The way the code is now, the snippet returns an error about bad grob
property
path (`foo') and "post-event expected."  No arpeggio appears.  With a
return of
item, we only get the warning about property path, and the arpeggio is
typeset.
This seems more sensible.

Indeed.  I'll take a look at other occurences of the pattern.

https://codereview.appspot.com/15850044/

_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to