https://codereview.appspot.com/60490050/diff/20001/Documentation/changes.tely File Documentation/changes.tely (right):
https://codereview.appspot.com/60490050/diff/20001/Documentation/changes.tely#newcode64 Documentation/changes.tely:64: @code{Partcombiner}'s handing of repeated note durations has been On 2014/02/08 13:41:04, dak wrote:
It has not been "improved" but rather made to work at all. Bug fix ->
we don't
mention it at all in the changes.
removed https://codereview.appspot.com/60490050/diff/20001/Documentation/changes.tely#newcode108 Documentation/changes.tely:108: Several @q{propeties} including chord, key and accidental changes are On 2014/02/08 13:41:04, dak wrote:
"properties". But this is a bit hand-wavy and confusing. Let's see:
Context properties named in the @samp{alternativeRestores} property
are restored
to their value at the start of the first alternative in subsequent
alternatives.
The default set restores measure position, current chord (for the sake
of
showing chord changes) and current meter.
Thanks. I'll make a new patch with some @lilypond examples as I think I get what is being said here and have created some simple examples. Although if you think I have missed the point, feel free to edit them. So this sounds like (and from my cursory experiments with lilypond-book compiling snippets) that bits of the NR http://lilypond.org/doc/v2.19/Documentation/notation/long-repeats are no longer needed now. --snip-- @lilypond[fragment,quote,relative=2] \partial 4 \repeat volta 2 { e4 | c2 e | } \alternative { { f2 d | \set Timing.measureLength = #(ly:make-moment 3/4) g4 g g % optional bar check is allowed here } { \set Timing.measureLength = #(ly:make-moment 4/4) a2 a | } } g1 | @end lilypond --snip-- When I compile this with and without the \set Timing command, it makes no difference at all. So is this what is now 'changed'? If so I'll make some edits in the NR too, while it is fresh in my head - but in a new patch for a new tracker.
End of proposal... key and accidentals are not yet in the current set
of
restored properties. It might make sense to put them there as well.
What is
somewhat tricky here is that the property restoration works via
iterators in
whatever context may get to see the \repeat/\volta stuff.
So the key stuff might behave trickily. We probably still want to try
it out
and see whether people complain. The safest bet is having
\repeat/\volta
everywhere where you want it, and it's also safer when using
\unfoldRepeats. https://codereview.appspot.com/60490050/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel