https://codereview.appspot.com/191260043/diff/1/elisp/lilypond-mode.el
File elisp/lilypond-mode.el (right):

https://codereview.appspot.com/191260043/diff/1/elisp/lilypond-mode.el#newcode112
elisp/lilypond-mode.el:112: (progn
This progn is unnecessary.  The old code gets an OMG from me.

https://codereview.appspot.com/191260043/diff/1/elisp/lilypond-mode.el#newcode1165
elisp/lilypond-mode.el:1165: (add-hook 'LilyPond-mode-hook (lambda ()
(turn-on-font-lock)))
(lambda () (turn-on-font-lock)) should just be #'turn-on-font-lock
instead.

But font-lock-mode is a global preference.  I don't think that modes
should unconditionally enable it.

https://codereview.appspot.com/191260043/

_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to