Thanks for the review!
https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm
File scm/output-lib.scm (right):
https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm#newcode1190
scm/output-lib.scm:1190: (shift (if (and (ly:grob? script-column)
On 2015/03/11 23:49:44, thomasmorley651 wrote:
minor nit:
Is it possible to stick to the 80 characters line-width?
Done.
https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm#newcode1196
scm/output-lib.scm:1196: (grob::has-interface s 'script-interface)
On 2015/03/12 00:01:35, thomasmorley651 wrote:
On 2015/03/11 23:49:44, thomasmorley651 wrote:
> Is there any need to go for AccidentalSuggestion and DynamicText?
> Deleting these conditions seems to make no difference:
>
> {
> \time 3/4
> \voiceOne
> c'!2.-.
> c'2.-. \ffff
> }
>
> Looks ok, even with unpatched 2.19.16
Ok, I'm wrong with Accidentalsuggestion, it makes a difference!
Though, I found no example for DynamicText, returning bad output with
2.19.16
Done.
You are right about DynamicText. Though it has script-interface, it
will not be caught in the 'scripts array of ScriptColumn. Check
removed.
https://codereview.appspot.com/207620043/
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
