Reviewers: ,
Message:
Please review
Description:
This fixes the issue of buggy documentation reported by Pierre and gets
rid of a TODO concerning padding not being needed now, replacing it with
changed alignment.
Please review this at https://codereview.appspot.com/225840043/
Affected files (+8, -9 lines):
M Documentation/learning/fundamental.itely
Index: Documentation/learning/fundamental.itely
diff --git a/Documentation/learning/fundamental.itely
b/Documentation/learning/fundamental.itely
index
108d200ca02a6298bb783ea019c07a25ebc58437..9bc66bd27ddb64ef7032b1c67e4c506730c7461d
100644
--- a/Documentation/learning/fundamental.itely
+++ b/Documentation/learning/fundamental.itely
@@ -3014,11 +3014,11 @@ violin = \new Staff {
However, you can also use these variables (also known as
macros, or user-defined commands) for tweaks:
-@c TODO Avoid padtext - not needed with skylining
@lilypond[quote,verbatim,ragged-right]
dolce = \markup { \italic \bold dolce }
-padText = { \once \override TextScript.padding = #5.0 }
+centreText = { \once \override TextScript.self-alignment-X = #CENTER }
+
fthenp =_\markup {
\dynamic f \italic \small { 2nd } \hspace #0.1 \dynamic p
}
@@ -3026,8 +3026,8 @@ fthenp =_\markup {
violin = \relative c'' {
\repeat volta 2 {
c4._\dolce b8 a8 g a b |
- \padText
- c4.^"hi there!" d8 e' f g d |
+ \centreText
+ c4.^"hi there!" d8 e f g d |
c,4.\fthenp b8 c4 c-. |
}
}
@@ -3036,7 +3036,6 @@ violin = \relative c'' {
{
\violin
}
- \layout { ragged-right = ##t }
}
@end lilypond
@@ -3051,9 +3050,9 @@ the last line.
violin = \relative c'' @{
\repeat volta 2 @{
c4._\markup @{ \italic \bold dolce @} b8 a8 g a b |
- \once \override TextScript.padding = #5.0
+ \once \override TextScript.self-alignment-X = #CENTER
c4.^"hi there!" d8 e' f g d |
- c,4.\markup @{
+ c,4._\markup @{
\dynamic f \italic \small @{ 2nd @} \hspace #0.1 \dynamic p
@}
b8 c4 c-. |
@@ -3062,9 +3061,9 @@ violin = \relative c'' @{
@end example
So far we've seen static substitution -- when LilyPond
-sees @code{\padText}, it replaces it with the stuff that
+sees @code{\centreText}, it replaces it with the stuff that
we've defined it to be (ie the stuff to the right of
-@code{padtext=}).
+@code{centreText=}).
LilyPond can handle non-static substitution, too (you
can think of these as functions).
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel