On 2015/07/12 17:49:44, thomasmorley651 wrote:
On 2015/07/12 17:01:06, dak wrote: >
https://codereview.appspot.com/258740043/diff/1/scm/define-markup-commands.scm
> File scm/define-markup-commands.scm (right): > >
https://codereview.appspot.com/258740043/diff/1/scm/define-markup-commands.scm#newcode542
> scm/define-markup-commands.scm:542: (+ table-page-number (+ 1 (* -1 > first-page-number)))) > Uh, (- table-page-number (1- first-page-number)) ?
done
Now I get second thoughts. The problem is that I actually have no clue how this calculation comes about. Is it because logical pages are counted from 1? If so, this likely should rather be (1+ (- table-page-number first-page-number)) instead. Basically, the calculation should reflect the underlying logic. Whatever that may be. https://codereview.appspot.com/258740043/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
