LGTM

https://codereview.appspot.com/258160043/diff/1/lily/font-config.cc
File lily/font-config.cc (right):

https://codereview.appspot.com/258160043/diff/1/lily/font-config.cc#newcode43
lily/font-config.cc:43: /* Create an empty configureation */
s/configureation/configuration/

https://codereview.appspot.com/258160043/diff/1/lily/font-config.cc#newcode70
lily/font-config.cc:70: error (_f ("failed adding fontconfig
configuration file: %s",
I think it's better to have

  failed to add fontconfig configuration file `foo'

instead of

  failed adding fontconfig configuration file: foo

https://codereview.appspot.com/258160043/diff/1/mf/99-lilypond-fonts.conf.in
File mf/99-lilypond-fonts.conf.in (right):

https://codereview.appspot.com/258160043/diff/1/mf/99-lilypond-fonts.conf.in#newcode1
mf/99-lilypond-fonts.conf.in:1: <?xml version="1.0" encoding="UTF-8"?>
just curious: Why is this `99-lilypond-fonts.conf.in' and not
`99-lilypond-fonts.conf'?  What can be configured in this file?

https://codereview.appspot.com/258160043/

_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to