Reviewers: HoangMinh, git, Message: On 2016/02/28 07:26:06, git wrote:
Is it OK to use tabs for indentation? It looks like whenever the original code did use them the modified
code also
uses them, even for subsequently added lines, while any *new* lines
that don't
refer to existing code are formatted correctly using spaces.
(I can't comment on the code itself, though)
See the comment at the start of lily/parser.yy. /* Mode and indentation are at best a rough approximation based on TAB * formatting (reasonable for compatibility with unspecific editor * modes as Bison modes are hard to find) and need manual correction * frequently. Without a reasonably dependable way of formatting a * Bison file sensibly, there is little point in trying to fix the * inconsistent state of indentation. */ However, it does not make sense that significant additions don't use TAB here. It is my guess that they stem from copy&paste operations or some over-eager magic at work: perhaps Emacs copies the indentation style from surrounding passages? I'll take a look and see whether the current change can be considered the minimal amount of extra mess, but won't put up a new review just for the spacing. Description: Issue 4779: Accept isolated durations as music function arguments Also contains commits: Use new arguments of make_duration Let make_duration accept preexisting durations and factor Let make_music_from_simple accept numbers/durations parser.yy: factor out "multipliers" from "multiplied_duration" parser.yy: Remove redundant duration_length Please review this at https://codereview.appspot.com/288380043/ Affected files (+153, -55 lines): M lily/parser.yy _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel