On 2018/11/10 19:44:47, pwm wrote:
Hi Charles, Today I built and ran 'make check' with your patch applied
to
current master. I was able to get it to pass 'make check' by making
the
following two changes.
1. In `chord-entry.scm` line 267, remove `(write-me "base3: " bass)`.
2. In that same file, line 100, remove the parens to change
`(chord-semantics)`
to just `chord-semantics`.
The first change fixed this error (but note the type check warning):
input/regression/chord-names-languages.ly'
~~~ Parsing... Renaming input to: `/home/james/lilypond-git/input/regression/chord-names-languages.ly' warning: type check for `bass' failed; value `(#t . #t)' must be of
type
`boolean'
/home/james/lilypond-git/build/out/share/lilypond/current/scm/chord-entry.scm:267:59:
In procedure memoization in expression (if ba ss (write-me "base3: " bass) ...):
/home/james/lilypond-git/build/out/share/lilypond/current/scm/chord-entry.scm:267:59:
In file "/home/james/lilypond-git/build/out/s hare/lilypond/current/scm/chord-entry.scm", line 266: Missing or extra expression in (if bass (write-me "base3: " bass) (list (make -note-ev bass (quote bass) #t)) (quote ())). ~~~
And the second change fixed this error:
input/regression/chord-name-entry.ly
~~~ $ /home/dev/lilypond-git/build/out/bin/lilypond input/regression/chord-name-entry.ly GNU LilyPond 2.21.0 Processing `input/regression/chord-name-entry.ly'
Parsing.../home/dev/lilypond-git/build/out/share/lilypond/current/scm/chord-entry.scm:100:35:
In expression (chord-semantics):
/home/dev/lilypond-git/build/out/share/lilypond/current/scm/chord-entry.scm:100:35:
Wrong type to apply: ((modifier . #f) (root . #<Pitch c' >) (extension
. 7)
(additions) (removals) (bass . #f)) ~~~
So if you have a chance to upload a new patch set with those two
changes, that
should get things moving forward with the code review process.
Cheers, -Paul
Thanks for figuring this out. I'm now working on make check, and will post a new patch shortly (I hope). https://codereview.appspot.com/337870043/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
