On 2020/01/16 10:57:46, dak wrote:
https://codereview.appspot.com/549350043/diff/545440043/configure.ac
File configure.ac (right):


https://codereview.appspot.com/549350043/diff/545440043/configure.ac#newcode8
configure.ac:8: [m4_esyscmd([. ${SRCDIR:-.}/VERSION; echo -n
$MAJOR_VERSION.$MINOR_VERSION.$PATCH_LEVEL])],
The proposal using m4_esyscmd_s allowed to use echo without -n option
(which is
a bit of a portability thing).  Was there a reason not to take it?

I didn't notice that you changed this and just took the changes with
SRCDIR. But is there an actual advantage of using m4_esyscmd_s?

https://codereview.appspot.com/549350043/

Reply via email to