On 2020/02/13 13:34:59, hanwenn wrote: > [...] > > https://codereview.appspot.com/557330043/diff/579310044/lily/include/overlay-string-port.hh > File lily/include/overlay-string-port.hh (right): > > https://codereview.appspot.com/557330043/diff/579310044/lily/include/overlay-string-port.hh#newcode50 > lily/include/overlay-string-port.hh:50: { > On 2020/02/13 11:02:59, hahnjo wrote: > > Is there an advantage of having the implementation in the header file? If not, > I > > think this should go to the .cc file. > > The advantage is simplicity; it's easier to synchronize the implementation and > declarations (especially with #ifdef). The cost is increased compile time, which > seeems overseeable since this is include only twice.
Ah, that trade-off seems fine then. https://codereview.appspot.com/557330043/
