On 2020/02/28 10:02:46, hanwenn wrote: > https://codereview.appspot.com/579340043/diff/571760043/lily/accidental-engraver.cc > File lily/accidental-engraver.cc (left): > > https://codereview.appspot.com/579340043/diff/571760043/lily/accidental-engraver.cc#oldcode338 > lily/accidental-engraver.cc:338: (long) trans); > On 2020/02/28 09:57:30, hahnjo wrote: > > On 2020/02/28 09:54:16, hanwenn wrote: > > > ouch - this is terrible. > > > > > > could we use a normal hash function to transform the pointer into a long > > > instead? > > > > Ideally yes, but I'm currently not interested to make this change. This code > has > > been here for a long time and frankly, I didn't understand why we need a > context > > here anyhow. > > > > Disclaimer: I haven't tried what happens if I just remove it or set it to > > constant 1 as other call sites do. > > no, don't do that. > > can you add a TODO instead?
Sure, opted for a FIXME and briefly explained what I think should be done. https://codereview.appspot.com/579340043/
