On 2020/04/21 00:43:02, dak wrote: > On 2020/04/20 23:26:07, Dan Eble wrote: > > On 2020/04/20 19:36:39, dak wrote: > > > Polish and extend tools in callback.hh > > > > LGTM. > > > > I have a hunch that the MFPn_WRAP macros could be turned into something more > > typical of C++, but I don't blame you for resting at this point. > > Not without a lot of effort since MFP1_WRAP and MFP2_WRAP rely on "trampoline" > in the current lexical scope doing something sensible. They are unclean macros. > So one would have to overhaul the whole trampoline concept to collect all > trampolines in one scope (either :: or Callback?::) and scatter specialisations > over the files that want them. A lot of work for what does not really look like > a whole lot of gain.
Also if you were thinking of turning MFP0_WRAP into a _function_ taking a pointer to member function argument, that will not work since the whole trampoline creation concept relies on the particular pointer to member being a template argument and thus fixed. There is a separate trampoline generated for each member function. https://codereview.appspot.com/551780043/
