https://codereview.appspot.com/577840053/diff/561760044/lily/lily-lexer.cc File lily/lily-lexer.cc (right):
https://codereview.appspot.com/577840053/diff/561760044/lily/lily-lexer.cc#newcode97 lily/lily-lexer.cc:97: Protected_scm Lily_lexer::keytable_; On 2020/04/27 21:22:59, hanwenn wrote: > could move out of Lily_lexer. It's only used in there and changing it elsewhere would be really bad, so why? https://codereview.appspot.com/577840053/diff/561760044/lily/lily-lexer.cc#newcode102 lily/lily-lexer.cc:102: if (!keytable_.is_bound ()) On 2020/04/27 21:22:59, hanwenn wrote: > move this to a global init function? There is no reason to this in the > constructor. It has to be done when the Scheme system is up and before the first call of a lexer. I'll take a look at moving it outside; skeptical it will be a win in readability/trustworthiness. In order to keep access to keytable_ private, the initialization will need to get done by a static member function. https://codereview.appspot.com/577840053/
