I will close this rietveld issue now that you are taking care of it. Whatever discussion needs to take place can happen at the one you have opened.
On Sat, May 02, 2020 at 11:54:14AM +0200, Han-Wen Nienhuys wrote: > See http://codereview.appspot.com/545970043 > > note: > 1) Depending on the renderer, the skylines diverge from the text. > Inkscape reproduces exactly, but EOG messes up the text formatting. > > 2) The lack of regression testing is worrying. We could have a section > of regtests that is powered by > > inkscape --export-background-opacity=1.0 --export-background=white > --export-type="png" svg.cropped.svg > > and then do imagemagick diffs on the result. > > On Sat, May 2, 2020 at 10:53 AM Kevin Barry <barr...@gmail.com> wrote: > > > > On Sat, May 02, 2020 at 09:59:18AM +0200, Han-Wen Nienhuys wrote: > > > Not necessarily, but the refactoring means I'll likely have to > > > overwrite the fix wholesale. Because there is no regtest, it willl > > > depend on my diligence anyway to fix this again. > > > > OK, so what should we do? I am happy to take responsibility for making > > sure it stays fixed after your work (even if that means another patch), > > but if there's some way I can rebase it off your work that would be fine > > too. > > > > -- > Han-Wen Nienhuys - hanw...@gmail.com - http://www.xs4all.nl/~hanwen
