On 2020/05/08 14:03:23, hanwenn wrote: > https://codereview.appspot.com/569700043/diff/582060043/lily/freetype.cc#newcode162 > lily/freetype.cc:162: } > On 2020/05/08 08:15:59, hahnjo wrote: > > This code looks very familiar. Don't we already have it in > > make_draw_bezier_boxes? > > yes.
So can we reuse that? > https://codereview.appspot.com/569700043/diff/582060043/lily/freetype.cc#newcode164 > lily/freetype.cc:164: else > On 2020/05/08 08:15:58, hahnjo wrote: > > I'd advocate another else if and have an assert in the else branch (but I know > > it's been this way in the old code) > > sure. But what would we assert? FT reserves the right to put other things in tag > bits. assert(false) that none of the previous cases was true? That should detect a breaking change in FT_Outline pretty quickly. https://codereview.appspot.com/569700043/
