On Thu, 2013-11-14 at 21:14 +0100, Jan-Peter Voigt wrote:
> On 14.11.2013 16:19, Joseph Rushton Wakeling wrote:
> >> there is an update of this snippet in the mail archives and I will post
> >> my version later.
> >
> > Fantastic, thank you! :-)
> so, here is the version I regularly use ... in fact, this is taken from
> some e-mail on this list some time ago. It also merges MultiMeasure rests.
I was just putting this code into Denemo and I noticed it merged a
multi-measure rest in the top voice with a sequence of whole measure
rests in the second voice, but it caused a segmentation fault in
LilyPond when it tries to merge multi measure rests from both voices.
The test file that shows this is attached. The include file is also
attached, it is the mergeRests.ly from the original message with the
example removed and convert-ly run on it to update it from 2.16.1 - the
resultant version reads 2.17.97 which I recall is a known bug.
I guess this part of the thread needs to switch to lilypond-devel or
lilypond-bug, now - I originally started this email just to enquire
about merging multi-measure rests ...
Richard
\version "2.18.0"
\include "merge-rests.ily"
% The music follows
MvmntIVoiceI = {
\voiceOne a'2. r4
\set Score.skipBars = ##t R1*4/4*2 }
MvmntIVoiceII = {
\voiceTwo e'2. r4
\set Score.skipBars = ##t R1*4/4*2 }
%Default Score Layout
\score {
<<
\new Staff <<
\new Voice = "VoiceIMvmntI" { \MvmntIVoiceI }
\new Voice = "VoiceIIMvmntI" { \MvmntIVoiceII }
>>
>>
\layout {
\mergeRests
}
}
\version "2.17.97"
%%% merge rests
#(define (rest-score r)
(let ((score 0)
(yoff (ly:grob-property-data r 'Y-offset))
(sp (ly:grob-property-data r 'staff-position)))
(if (number? yoff)
(set! score (+ score 2))
(if (eq? yoff 'calculation-in-progress)
(set! score (- score 3))))
(and (number? sp)
(<= 0 2 sp)
(set! score (+ score 2))
(set! score (- score (abs (- 1 sp)))))
score))
#(define (merge-rests-on-positioning grob)
(let* ((can-merge #f)
(elts (ly:grob-object grob 'elements))
(num-elts (and (ly:grob-array? elts)
(ly:grob-array-length elts)))
(two-voice? (= num-elts 2)))
(if two-voice?
(let* ((v1-grob (ly:grob-array-ref elts 0))
(v2-grob (ly:grob-array-ref elts 1))
(v1-rest (ly:grob-object v1-grob 'rest))
(v2-rest (ly:grob-object v2-grob 'rest)))
(and
(ly:grob? v1-rest)
(ly:grob? v2-rest)
(let* ((v1-duration-log (ly:grob-property v1-rest 'duration-log))
(v2-duration-log (ly:grob-property v2-rest 'duration-log))
(v1-dot (ly:grob-object v1-rest 'dot))
(v2-dot (ly:grob-object v2-rest 'dot))
(v1-dot-count (and (ly:grob? v1-dot)
(ly:grob-property v1-dot 'dot-count -1)))
(v2-dot-count (and (ly:grob? v2-dot)
(ly:grob-property v2-dot 'dot-count -1))))
(set! can-merge
(and
(number? v1-duration-log)
(number? v2-duration-log)
(= v1-duration-log v2-duration-log)
(eq? v1-dot-count v2-dot-count)))
(if can-merge
;; keep the rest that looks best:
(let* ((keep-v1? (>= (rest-score v1-rest)
(rest-score v2-rest)))
(rest-to-keep (if keep-v1? v1-rest v2-rest))
(dot-to-kill (if keep-v1? v2-dot v1-dot)))
;; uncomment if you're curious of which rest was chosen:
;;(ly:grob-set-property! v1-rest 'color green)
;;(ly:grob-set-property! v2-rest 'color blue)
(ly:grob-suicide! (if keep-v1? v2-rest v1-rest))
(if (ly:grob? dot-to-kill)
(ly:grob-suicide! dot-to-kill))
(ly:grob-set-property! rest-to-keep 'direction 0)
(ly:rest::y-offset-callback rest-to-keep)))))))
(if can-merge
#t
(ly:rest-collision::calc-positioning-done grob))))
#(define merge-multi-measure-rests-on-Y-offset
;; Call this to get the 'Y-offset of a MultiMeasureRest.
;; It keeps track of other MultiMeasureRests in the same
NonMusicalPaperColumn
;; and StaffSymbol. If two are found, delete one and return 1 for Y-offset of
;; the other one.
(let ((table (make-weak-key-hash-table)))
(lambda (grob)
(let* ((ssymb (ly:grob-object grob 'staff-symbol))
(nmcol (ly:grob-parent grob X))
(ssymb-hash (or (hash-ref table ssymb)
(hash-set! table ssymb (make-hash-table))))
(othergrob (hash-ref ssymb-hash nmcol)))
(if (ly:grob? othergrob)
(begin
;; Found the other grob in this staff/column,
;; delete it and move ours.
(ly:grob-suicide! othergrob)
(hash-remove! ssymb-hash nmcol)
1) ; was 0
(begin
;; Just save this grob and return the default value.
(hash-set! ssymb-hash nmcol grob)
(ly:staff-symbol-referencer::callback grob)))))))
mergeRestsOn = {
\override Staff.RestCollision.positioning-done = #merge-rests-on-positioning
\override Staff.MultiMeasureRest.Y-offset =
#merge-multi-measure-rests-on-Y-offset
}
mergeRestsOff = {
\revert Staff.RestCollision.positioning-done
\revert Staff.MultiMeasureRest.Y-offset
}
mergeRests = \layout {
\context {
\Staff
\override RestCollision.positioning-done = #merge-rests-on-positioning
\override MultiMeasureRest.Y-offset = #merge-multi-measure-rests-on-Y-offset
}
}
_______________________________________________
lilypond-user mailing list
lilypond-user@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-user
