On Tue, 15 Feb 2011, Vishwanath Sripathy wrote:
> Hi Nicolas,
>
> Pls find attached the patch set for supporting DVFS feature on OMAP.
> These patches have been generated against latest Linaro 2.6.37 tree
> and tested on OMAP3430 and ZOOM3.
>
> Note that these patches are already posted to linux omap mailing list
> (https://patchwork.kernel.org/patch/495021/) and they are under
> discussion. So I have prefixed these patches as WIP. Kindly merge
> these patches for 11.05 release.
A few notes on those patches:
1) Please CC linaro-dev next time so other people are aware of what you
did, what you sent me, etc. I've added it to this reply. This way
at least if nothing happens with your patches it's easier to put the
blame on me. :-)
2) Your cover message contains this in plain sight in the diffstat part:
mode change 100644 => 100755 arch/arm/mach-omap2/voltage.c
mode change 100644 => 100755 arch/arm/plat-omap/cpu-omap.c
This is clearly wrong to flag .c files as executables, so you should
take care to fix that and understand why this happened in the first
place. Incidentally this mode change does not appear in any of your
patches.
3) All your patches were numbered, except for:
V4-OMAP3-PM-Set-clear-T2-bit-for-Smartreflex-on-TWL.patch
Since I'm sure you know better than I do where that patch should be
applied in the series (if at all) you should rename it appropriately,
or at least let me know in which order to apply it (I initially
applied it last based on the date recorded in the patch but that
didn't work out).
4) This patch is a bit thin on explanation:
[PATCH 08/13] [PM WIP OMAP] OMAP3: cpufreq driver changes for DVFS
support
Changes in the omap cpufreq driver for DVFS support.
Signed-off-by: Vishwanath BS <vishwanath...@ti.com>
What are those changes? It is not obvious to me looking at the
patch. All the other patches are sufficiently documented.
I've applied them to the linaro-2.6.37 branch. Please note that the
11.05 Linaro release will be based on a 2.6.38 branch I'm about to
create. Can you tell me what is the likelyhood for those patches to be
merged upstream for the next merge window?
Nicolas
_______________________________________________
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
