On Mon, Mar 28, 2011 at 4:56 PM, Daniel Lezcano <daniel.lezc...@free.fr>wrote:
> On 03/28/2011 08:28 AM, Yong Shen wrote: > >> On Sun, Mar 27, 2011 at 5:06 AM, Daniel Lezcano<daniel.lezc...@free.fr >> >wrote: >> >> By moving the functions in the right order in the file, we can get ride >>> of their definitions and we can set them static. >>> >>> Technically, those function names in head files should be declarations, >> not >> definitions. >> > > Right, I meant "declarations", thanks. > > For this patch, it could be further split, since it is a little bit messed >> up, for example: for print_clock_info(), you moved it from the original >> place, but for others, it is really hard to see this. It looks like you >> removed it and then changed collapse_all_subclocks to a new >> print_clock_info somehow. >> >> > Yep, sometimes the changes are trivial (here just moving the functions up) > but the diff result is hard to understand. > I can split this patch into several but is it really worth to do that ? > Personally, I am OK with this as long as it does not let errors creep in. It is Amit's call for the acceptance of this patch. Yong
_______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
