-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 06/27/2011 09:36 AM, Milo (Woogyom) Kim wrote: > > Hi, Daniel > > I found some segmentation fault in the powerdebug. > If there is no clock information, then windata[win].rowdata is null. > (If clock_display() returns -1, then display_set_row_data() is not called) > In this case the seg fault error occurs when display_get_row_data() is > called.
Thanks Milo for reporting the problem. I opened a bug in launchpad for this: https://bugs.launchpad.net/linaro-powerdebug/+bug/802387 Your patches are fixing the problem but I think that does not fix the root problem which is we are setting the display ops on the clocks. At the first glance, I think we should not call display_register in the clock_init function if we are not able to access debugfs. The same should apply to all init function for the different subsystems. (cc'ed linaro-dev) -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJOCD4vAAoJEAKBbMCpUGYAvW4IALXI8nNyrtiej97/9gjFBhZT cfHZgAgY5f4J+GoCyxX2tyCfbqkHgDGaJDvAWkWxMjBLQiVpnjchOG96aj+o5qud YQ3vFXuLKmXWyAjxhxuXfOKyjhvHf6QcKLXWS7OMBoxfozYJ0EwEvSjfGVL2sF3e rurZVZYU47Ms8jVq/MzaEyi1GZiE5D6ZhjfuSc9XhJ70+NORaVcgChOE3E2XGh5O DfKjFHfr/nsjVGXPp0vTdlHH4ZgecDCkuorK8a9Bi0xX7ijRVUUVgjepuK/Fflqo 33/I995r2utVK+x/FgcyNBi28qhNieeVIBcVdZHEFKGPCiGFdbGkqz2JDagJxnc= =99OZ -----END PGP SIGNATURE----- _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
