Dear "David A. Long",
In message <20110708175540.2334.92924.stgit@dave-Dell-System-XPS-L502X> you
wrote:
> From: David A. Long <[email protected]>
>
> Add a new "fdt_high" enviroment variable. This can be used to control (or
> prevent) the
> relocation of the flattened device tree on boot. It can be used to prevent
> relocation
> of the fdt into highmem. The variable behaves similarly to the existing
> "initrd_high"
> variable.
>
> Signed-off-by: David A. Long <[email protected]>
> ---
> common/image.c | 45 +++++++++++++++++++++++++++++++++++----------
> 1 files changed, 35 insertions(+), 10 deletions(-)
Please add appropriate documentation to the README as well.
> + of_start = (void *)(unsigned long)lmb_alloc_base(lmb, of_len,
> 0x1000, ((ulong) desired_addr) + of_len);
Line too long. Please fix globally.
> + if(of_start != desired_addr) {
> + puts("Failed using fdt_high value for Device Tree");
> + goto error;
> + }
> + } else
> + of_start = (void *)(unsigned long)lmb_alloc_base(lmb, of_len,
> 0x1000,
> getenv_bootm_mapsize() + getenv_bootm_low());
In U-Boot we require braces around multi-line statements.
The alignment of the second line is not corrrect as well.
And Cc: the U-Boot ML, please.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]
Too many people are ready to carry the stool when the piano needs to
be moved.
_______________________________________________
linaro-dev mailing list
[email protected]
http://lists.linaro.org/mailman/listinfo/linaro-dev
