On 23 August 2011 23:56, Nicolas Pitre <nicolas.pi...@linaro.org> wrote: > On Tue, 23 Aug 2011, Venkatraman S wrote: > >> From: Venkatraman S <ven...@linaro.org> >> >> >> Signed-off-by: Venkatraman S <ven...@linaro.org> >> --- >> drivers/gpio/gpio-exynos4.c | 2 +- >> drivers/gpio/gpio-nomadik.c | 2 +- >> drivers/gpio/gpio-s5pv210.c | 1 + >> drivers/gpio/pl061.c | 1 + > > Same issue as for patch #14/24. One of the big issue with the GPIO code > is its reliance on <mach/gpio.h> which has to be solved already, since > in a multi SOC kernel we just don't know which of the many <mach/irqs.h> > we want to include. > > I think that one of the solution for this would involve making > <mach/*.h> into <mach/$soc_name/*.h> up front... meaning that we recurse > again another level down with all its implications. > > Thanks for the review. Can't we just rename the files then ? gpio-exynos.h gpio-nomadik.h and so on, and move all, or part of the contents to drivers ?
_______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
