On Sun, Mar 18, 2012 at 7:07 AM, Shawn Guo <shawn....@linaro.org> wrote: > Another trivial comment. But if there is an incremental patch, maybe > consider to include it. > > On Thu, Mar 15, 2012 at 11:11:19PM -0700, Mike Turquette wrote: > ... >> +#ifdef CONFIG_COMMON_CLK_DISABLE_UNUSED >> +static int clk_disable_unused(void) >> +{ >> + struct clk *clk; >> + struct hlist_node *tmp; >> + >> + mutex_lock(&prepare_lock); >> + >> + hlist_for_each_entry(clk, tmp, &clk_root_list, child_node) >> + clk_disable_unused_subtree(clk); >> + >> + hlist_for_each_entry(clk, tmp, &clk_orphan_list, child_node) >> + clk_disable_unused_subtree(clk); >> + >> + mutex_unlock(&prepare_lock); >> + >> + return 0; >> +} >> +late_initcall(clk_disable_unused); >> +#else >> +static inline int clk_disable_unused(struct clk *clk) { return 0; } > > This #else block seems completely unnecessary to me. > >> +#endif /* CONFIG_COMMON_CLK_DISABLE_UNUSED */
Oops. This is a leftover from when there was a separate drivers/clk/clk-debug.c which implemented this stuff. I'll make a cleanup series and roll all these little things into it. Thanks, Mike _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev