On Wed, Apr 11, 2012 at 06:02:51PM -0700, Mike Turquette wrote: > This patch is the basic clk version of 'clk: core: copy parent_names & > return error codes'. > > The registration functions are changed to allow the core code to copy > the array of strings and allow platforms to declare those arrays as > __initdata. > > This patch also converts all of the basic clk registration functions to > return error codes which better aligns them with the existing clk.h api. > > > + */ > struct clk *clk_register_divider(struct device *dev, const char *name, > const char *parent_name, unsigned long flags, > void __iomem *reg, u8 shift, u8 width, > u8 clk_divider_flags, spinlock_t *lock) > { > struct clk_divider *div; > - struct clk *clk; > + struct clk *clk = ERR_PTR(-ENOMEM); > + const char *parent_names[1]; > > + /* allocate the divider */ > div = kzalloc(sizeof(struct clk_divider), GFP_KERNEL); > - > if (!div) { > pr_err("%s: could not allocate divider clk\n", __func__); > return NULL;
You missed a conversion to ERR_PTR here. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev