On Thu, Feb 21, 2013 at 02:24:23PM -0800, Anton Vorontsov wrote:
> On Thu, Feb 21, 2013 at 06:32:40PM +0800, Hongbo Zhang wrote:
> > These NTC resistance to temperature tables should be public, so others such
> > as
> > ab8500 hwmon driver can look up these tables to convert NTC resistance to
> > temperature.
> >
> > Signed-off-by: Hongbo Zhang <hongbo.zh...@linaro.org>
> > ---
>
> For 1/3 and 2/3 patches:
>
> Acked-by: Anton Vorontsov <an...@enomsg.org>
>
> (Do you need EXPORT_SYMBOL()? You don't use this from modules?)
>
I would think so. Also, the variables should be exported through an include
file.
The variable names are quite generic for global variables; we need to find
something more specific/descriptive.
There is also some overlap with functionality in drivers/hwmon/ntc_thermistor.c.
Wonder if it would be possible to unify the code.
Guenter
> Thanks.
>
> > drivers/power/ab8500_bmdata.c | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/power/ab8500_bmdata.c b/drivers/power/ab8500_bmdata.c
> > index f034ae4..53f3324 100644
> > --- a/drivers/power/ab8500_bmdata.c
> > +++ b/drivers/power/ab8500_bmdata.c
> > @@ -11,7 +11,7 @@
> > * Note that the res_to_temp table must be strictly sorted by falling
> > resistance
> > * values to work.
> > */
> > -static struct abx500_res_to_temp temp_tbl_A_thermistor[] = {
> > +struct abx500_res_to_temp temp_tbl_A_thermistor[] = {
> > {-5, 53407},
> > { 0, 48594},
> > { 5, 43804},
> > @@ -29,7 +29,9 @@ static struct abx500_res_to_temp temp_tbl_A_thermistor[]
> > = {
> > {65, 12500},
> > };
> >
> > -static struct abx500_res_to_temp temp_tbl_B_thermistor[] = {
> > +int temp_tbl_A_size = ARRAY_SIZE(temp_tbl_A_thermistor);
> > +
> > +struct abx500_res_to_temp temp_tbl_B_thermistor[] = {
> > {-5, 200000},
> > { 0, 159024},
> > { 5, 151921},
> > @@ -47,6 +49,8 @@ static struct abx500_res_to_temp temp_tbl_B_thermistor[]
> > = {
> > {65, 82869},
> > };
> >
> > +int temp_tbl_B_size = ARRAY_SIZE(temp_tbl_B_thermistor);
> > +
> > static struct abx500_v_to_cap cap_tbl_A_thermistor[] = {
> > {4171, 100},
> > {4114, 95},
> > --
> > 1.8.0
>
_______________________________________________
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
