Hi Sanjay, Both patches look OK. You should mention the bug number in your commit message to show that it solves an open bug.
Regards, Amit On Mon, Apr 8, 2013 at 5:39 PM, Sanjay Singh Rawat <sanjay.ra...@linaro.org> wrote: > pmqa should be on a RW permission partition. Need to change the path > in lava pm-qa script too. > > Signed-off-by: Sanjay Singh Rawat <sanjay.ra...@linaro.org> > --- > cpufreq/Android.mk | 2 +- > cpuhotplug/Android.mk | 4 ++-- > cpuidle/Android.mk | 4 ++-- > include/Android.mk | 2 +- > sched_mc/Android.mk | 2 +- > suspend/Android.mk | 2 +- > thermal/Android.mk | 2 +- > utils/Android.mk | 2 +- > 8 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/cpufreq/Android.mk b/cpufreq/Android.mk > index 2fa747f..2da6056 100644 > --- a/cpufreq/Android.mk > +++ b/cpufreq/Android.mk > @@ -10,7 +10,7 @@ define $(module_name)_add_executable > LOCAL_MODULE := $1.sh > systemtarball: $1.sh > LOCAL_SRC_FILES := $1.sh > - LOCAL_MODULE_PATH := > $(TARGET_OUT_OPTIONAL_EXECUTABLES)/pm-qa/$(module_name) > + LOCAL_MODULE_PATH := $(TARGET_OUT_DATA)/benchmark/pm-qa/$(module_name) > include $(BUILD_PREBUILT) > endef > > diff --git a/cpuhotplug/Android.mk b/cpuhotplug/Android.mk > index fda35a9..c0e5694 100644 > --- a/cpuhotplug/Android.mk > +++ b/cpuhotplug/Android.mk > @@ -10,7 +10,7 @@ define $(module_name)_add_executable > LOCAL_MODULE := $1.sh > systemtarball: $1.sh > LOCAL_SRC_FILES := $1.sh > - LOCAL_MODULE_PATH := > $(TARGET_OUT_OPTIONAL_EXECUTABLES)/pm-qa/$(module_name) > + LOCAL_MODULE_PATH := $(TARGET_OUT_DATA)/benchmark/pm-qa/$(module_name) > include $(BUILD_PREBUILT) > endef > > @@ -24,7 +24,7 @@ define $(module_name)_etc_add_executable > LOCAL_MODULE := $1.sh > systemtarball: $1.sh > LOCAL_SRC_FILES := $1.sh > - LOCAL_MODULE_PATH := > $(TARGET_OUT_OPTIONAL_EXECUTABLES)/pm-qa/$(module_name) > + LOCAL_MODULE_PATH := $(TARGET_OUT_DATA)/benchmark/pm-qa/$(module_name) > include $(BUILD_PREBUILT) > endef > > diff --git a/cpuidle/Android.mk b/cpuidle/Android.mk > index d85d0c0..2f302d7 100644 > --- a/cpuidle/Android.mk > +++ b/cpuidle/Android.mk > @@ -10,7 +10,7 @@ define $(module_name)_add_executable > LOCAL_MODULE := $1.sh > systemtarball: $1.sh > LOCAL_SRC_FILES := $1.sh > - LOCAL_MODULE_PATH := > $(TARGET_OUT_OPTIONAL_EXECUTABLES)/pm-qa/$(module_name) > + LOCAL_MODULE_PATH := $(TARGET_OUT_DATA)/benchmark/pm-qa/$(module_name) > include $(BUILD_PREBUILT) > endef > > @@ -23,5 +23,5 @@ systemtarball: cpuidle_killer > LOCAL_SRC_FILES:= cpuidle_killer.c > LOCAL_STATIC_LIBRARIES := libcutils libc > LOCAL_MODULE_TAGS := tests > -LOCAL_MODULE_PATH := $(TARGET_OUT_OPTIONAL_EXECUTABLES)/pm-qa/$(module_name) > +LOCAL_MODULE_PATH := $(TARGET_OUT_DATA)/benchmark/pm-qa/$(module_name) > include $(BUILD_EXECUTABLE) > diff --git a/include/Android.mk b/include/Android.mk > index ec1e704..9560fc1 100644 > --- a/include/Android.mk > +++ b/include/Android.mk > @@ -10,7 +10,7 @@ define $(module_name)_etc_add_executable > LOCAL_MODULE := $1.sh > systemtarball: $1.sh > LOCAL_SRC_FILES := $1.sh > - LOCAL_MODULE_PATH := > $(TARGET_OUT_OPTIONAL_EXECUTABLES)/pm-qa/$(module_name) > + LOCAL_MODULE_PATH := $(TARGET_OUT_DATA)/benchmark/pm-qa/$(module_name) > include $(BUILD_PREBUILT) > endef > > diff --git a/sched_mc/Android.mk b/sched_mc/Android.mk > index f9f9d90..69032e8 100644 > --- a/sched_mc/Android.mk > +++ b/sched_mc/Android.mk > @@ -10,7 +10,7 @@ define $(module_name)_add_executable > LOCAL_MODULE := $1.sh > systemtarball: $1.sh > LOCAL_SRC_FILES := $1.sh > - LOCAL_MODULE_PATH := > $(TARGET_OUT_OPTIONAL_EXECUTABLES)/pm-qa/$(module_name)_mc > + LOCAL_MODULE_PATH := $(TARGET_OUT_DATA)/benchmark/pm-qa/$(module_name)_mc > include $(BUILD_PREBUILT) > endef > > diff --git a/suspend/Android.mk b/suspend/Android.mk > index 096e551..d394401 100644 > --- a/suspend/Android.mk > +++ b/suspend/Android.mk > @@ -10,7 +10,7 @@ define $(module_name)_add_executable > LOCAL_MODULE := $1.sh > systemtarball: $1.sh > LOCAL_SRC_FILES := $1.sh > - LOCAL_MODULE_PATH := > $(TARGET_OUT_OPTIONAL_EXECUTABLES)/pm-qa/$(module_name) > + LOCAL_MODULE_PATH := $(TARGET_OUT_DATA)/benchmark/pm-qa/$(module_name) > include $(BUILD_PREBUILT) > endef > > diff --git a/thermal/Android.mk b/thermal/Android.mk > index 3f0b958..d950a14 100644 > --- a/thermal/Android.mk > +++ b/thermal/Android.mk > @@ -10,7 +10,7 @@ define $(module_name)_add_executable > LOCAL_MODULE := $1.sh > systemtarball: $1.sh > LOCAL_SRC_FILES := $1.sh > - LOCAL_MODULE_PATH := > $(TARGET_OUT_OPTIONAL_EXECUTABLES)/pm-qa/$(module_name) > + LOCAL_MODULE_PATH := $(TARGET_OUT_DATA)/benchmark/pm-qa/$(module_name) > include $(BUILD_PREBUILT) > endef > > diff --git a/utils/Android.mk b/utils/Android.mk > index 272a70c..b49fa45 100644 > --- a/utils/Android.mk > +++ b/utils/Android.mk > @@ -10,7 +10,7 @@ define $(module_name)_etc_add_executable > LOCAL_MODULE := $1 > systemtarball: $1 > LOCAL_SRC_FILES := $1.c > - LOCAL_MODULE_PATH := > $(TARGET_OUT_OPTIONAL_EXECUTABLES)/pm-qa/$(module_name) > + LOCAL_MODULE_PATH := $(TARGET_OUT_DATA)/benchmark/pm-qa/$(module_name) > include $(BUILD_EXECUTABLE) > endef > > -- > 1.7.9.5 > > > _______________________________________________ > linaro-dev mailing list > linaro-dev@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/linaro-dev _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
