On 20 June 2013 09:40, Jingoo Han <jg1....@samsung.com> wrote: > On Thursday, June 13, 2013 12:54 AM, Manjunath Goudar wrote: > > > > Separate the Samsung OHCI EXYNOS host controller driver from ohci-hcd > > host code so that it can be built as a separate driver module. > > This work is part of enabling multi-platform kernels on ARM; > > it would be nice to have in 3.11. > > > > V2: > > -exynos_ohci_hcd structure assignment error fixed. > > -Removed multiple usb_create_hcd() from prob funtion. > > -platform_set_drvdata() called before exynos_ohci_phy_enable(). > > -ohci_setup() removed because it is called in .reset member > > of the ohci_hc_driver structure > > > > Signed-off-by: Manjunath Goudar <manjunath.gou...@linaro.org> > > Cc: Arnd Bergmann <a...@arndb.de> > > Cc: Jingoo Han <jg1....@samsung.com> > > Cc: Kukjin Kim <kgene....@samsung.com> > > Cc: Greg KH <g...@kroah.com> > > Cc: Alan Stern <st...@rowland.harvard.edu> > > Cc: linux-...@vger.kernel.org > > --- > > drivers/usb/host/Kconfig | 2 +- > > drivers/usb/host/Makefile | 1 + > > drivers/usb/host/ohci-exynos.c | 167 > +++++++++++++++++----------------------- > > drivers/usb/host/ohci-hcd.c | 18 ----- > > 4 files changed, 71 insertions(+), 117 deletions(-) > > CC'ed Vivek Gautam > > Hi Manjunath Goudar, > > It looks good. > I tested this patch on Exynos4210. It works properly. > I really appreciate your work. > > Acked-by: Jingoo Han <jg1....@samsung.com> > > > Also, I agree on Alan's opinion. > > +#define DRIVER_DESC "OHCI exynos driver" > Please, replace 'exynos' with 'EXYNOS'. > > Thank you very much. I fixed his comment in V3,when I am sending V3 vesrion I will add CC to Vivek Gautam.
Thanks Manjunath Goudar Best regards, > Jingoo Han > > >
_______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
